feat(dialog): add 'custom-content' slot #11072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto dit13711/10323-rename-dialog-content-slot
…nto dit13711/10323-rename-dialog-content-slot
driskull
requested changes
Dec 16, 2024
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
…nto dit13711/10323-rename-dialog-content-slot
github-actions
bot
removed
the
Stale
…nto dit13711/10323-rename-dialog-content-slot
driskull
requested changes
Jan 28, 2025
DitwanP
changed the title
github-actions
bot
added
the
enhancement
|
Looks to be working in all browsers: |
driskull
approved these changes
Jan 28, 2025
DitwanP
added
skip visual snapshots
DitwanP
changed the title
github-actions
bot
added this to the 2025-02-06 - 3.0.0 Feb Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10323
Summary
Deprecates the
"content"slot in favor of a new"custom-content"slot that will clearly describes the behavior that a user can expect. This change should solve the issue of confusion that we've heard about from internal feedback.The description of the new slot would be:
deprecate(dialog): deprecate the
contentslot